better pastSubjunctive english

This commit is contained in:
lingdocs 2022-07-19 16:24:58 -05:00
parent 71b13463cd
commit 86f99f58ad
3 changed files with 13 additions and 9 deletions

View File

@ -1,6 +1,6 @@
{
"name": "@lingdocs/pashto-inflector",
"version": "3.4.2",
"version": "3.4.3",
"author": "lingdocs.com",
"description": "A Pashto inflection and verb conjugation engine, inculding React components for displaying Pashto text, inflections, and conjugations",
"homepage": "https://verbs.lingdocs.com",

View File

@ -141,10 +141,13 @@ export function renderEnglishVPBase({ subjectPerson, object, vs }: {
]),
wouldBePerfect: (s: T.Person, v: T.EnglishVerbConjugationEc, n: boolean) => ([
`$SUBJ would${n ? " not" : ""} have ${v[4]}`,
`$SUBJ had probably ${n ? " not" : ""} ${v[4]}`,
]),
pastSubjunctivePerfect: (s: T.Person, v: T.EnglishVerbConjugationEc, n: boolean) => ([
`$SUBJ would${n ? " not" : ""} have ${v[4]}`,
`$SUBJ should${n ? " not" : ""} have ${v[4]}`,
`$SUBJ ${n ? "didn't have" : "had"} to ${v[0]}`,
`$SUBJ had${n ? " not" : ""} to have ${v[4]}`,
`$SUBJ would${n ? " not" : ""} have ${v[4]}`,
]),
wouldHaveBeenPerfect: (s: T.Person, v: T.EnglishVerbConjugationEc, n: boolean) => ([
`$SUBJ would${n ? " not" : ""} have ${v[4]}`,

View File

@ -188,18 +188,19 @@ const equativeBuilders: Record<T.EquativeTense, (p: T.Person, n: boolean) => str
`$SUBJ ${getEnglishConj(p, g.englishEquative.past)} probably${not(n)} $PRED`,
];
},
pastSubjunctive: () => {
pastSubjunctive: (p, n) => {
return [
`$SUBJ should have been $PRED`,
`(that) $SUBJ were $PRED`,
`$SUBJ should ${n ? "not " : ""}have been $PRED`,
`$SUBJ had to ${n ? "not " : ""}be $PRED`,
`(that) $SUBJ were ${n ? "not " : ""}$PRED`,
];
},
wouldHaveBeen: () => {
wouldHaveBeen: (p, n) => {
return [
`$SUBJ would have been $PRED`,
`$SUBJ would ${n ? "not " : ""}have been $PRED`,
];
}
}
},
};
function isThirdPersonSing(p: T.Person): boolean {
return p === T.Person.ThirdSingMale || p === T.Person.ThirdPlurFemale;