From 411f5b2d04de311aa21b37e6b102a22cc27580b8 Mon Sep 17 00:00:00 2001 From: adueck Date: Thu, 8 Feb 2024 22:51:27 +0100 Subject: [PATCH] fixed issue with intransitive verbs not checking for subject agreement --- src/lib/src/parsing/parse-vp.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/lib/src/parsing/parse-vp.ts b/src/lib/src/parsing/parse-vp.ts index a5dfd0b..660d08c 100644 --- a/src/lib/src/parsing/parse-vp.ts +++ b/src/lib/src/parsing/parse-vp.ts @@ -29,9 +29,6 @@ import { isSecondPerson, personToGenNum } from "../misc-helpers"; import { equals, zip } from "rambda"; import { isImperativeTense } from "../type-predicates"; // to hide equatives type-doubling issue -// TODO: THESE SHOULD ERROR!! -// ماشومانې لاړل -// ماشومان لاړلې // TODO: problem with 3rd pers seng verb endings اواز مې دې واورېده @@ -324,6 +321,11 @@ function finishIntransitive({ message: "subject of intransitive verb must not be inflected", }); } + if (subjectPerson !== person) { + errors.push({ + message: "subject and verb must agree for intransitive verb", + }); + } const blocks: T.VPSBlockComplete[] = [ ...mapOutnpsAndAps(["S"], npsAndAps), {