oops big bug with not checking the pronoun conflicts correctly

This commit is contained in:
lingdocs 2022-03-27 16:45:29 +05:00
parent 6b8842c9b1
commit 4f79456115
2 changed files with 6 additions and 5 deletions

View File

@ -27,8 +27,9 @@ export function PhraseBuilder() {
function handleObjectChange(object: NPSelection | undefined) { function handleObjectChange(object: NPSelection | undefined) {
if (!verb) return; if (!verb) return;
if ((verb.object === "none") || (typeof verb.object === "number")) return; if ((verb.object === "none") || (typeof verb.object === "number")) return;
console.log("handling object change and checking", object);
// check for pronoun conflict // check for pronoun conflict
if (hasPronounConflict(subject, verb.object)) { if (hasPronounConflict(subject, object)) {
alert("That combination of pronouns is not allowed"); alert("That combination of pronouns is not allowed");
return; return;
} }

View File

@ -1684,10 +1684,10 @@
pbf "^3.2.1" pbf "^3.2.1"
rambda "^6.7.0" rambda "^6.7.0"
"@lingdocs/pashto-inflector@^1.5.5": "@lingdocs/pashto-inflector@^1.5.7":
version "1.5.5" version "1.5.7"
resolved "https://npm.lingdocs.com/@lingdocs%2fpashto-inflector/-/pashto-inflector-1.5.5.tgz#166e0181711cf019aef2e637bc798c3f41e8df8d" resolved "https://npm.lingdocs.com/@lingdocs%2fpashto-inflector/-/pashto-inflector-1.5.7.tgz#bf13805208ed6d62eee6f11e809baef7c603a124"
integrity sha512-NK5slwLJrMTdS/whYoSjvtRQgN9vdy+PFJxecih7HgcaSEwfFVy+wxWXLwufznpGI4VCoDgIo4+gWNkNxvAt3Q== integrity sha512-4SS8Qgab2RkDAup4ODxA3J5R0nHHgUj/9grVO0zozq36lFwuvARhsSNp9kPPTAb++1kih7yKyW7HG5NGYavSlw==
dependencies: dependencies:
classnames "^2.2.6" classnames "^2.2.6"
pbf "^3.2.1" pbf "^3.2.1"